[asterisk-dev] [Code Review] 2964: res_pjsip_outbound_registration: Add "virtual line" support for automatic inbound matching

[opticron]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2964/#review13418
-----------------------------------------------------------



/trunk/res/res_pjsip_outbound_registration.c
<https://reviewboard.asterisk.org/r/2964/#comment23942>

    pj_create_random_string() does not NULL-terminate the buffer when generating the string. This should be taken care of manually and space allotted for the NULL terminator.


- opticron


On Sept. 13, 2014, 5:44 a.m., Joshua Colp wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2964/
> -----------------------------------------------------------
> 
> (Updated Sept. 13, 2014, 5:44 a.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> This patch adds "virtual line" support to the res_pjsip_outbound_registration module. This is an optional feature and simply adds a "line" URI parameter to the Contact we place in the outbound registration. If this line parameter is present on incoming requests we use it to establish a relationship to the outbound registration and match it to a user configured endpoint. This has the benefit that when registering to another server where it is supported you no longer have to do IP based matching for all of their potential servers. The downside (and why this is optional) is that if a third party got the line parameter they could send you calls as if they were the legit remote server.
> 
> 
> Diffs
> -----
> 
>   /trunk/res/res_pjsip_outbound_registration.c 423063 
>   /trunk/configs/samples/pjsip.conf.sample 423063 
> 
> Diff: https://reviewboard.asterisk.org/r/2964/diff/
> 
> 
> Testing
> -------
> 
> Registered to an ITSP, placed an inbound call from them, confirmed matched using line parameter.
> 
> Registered to a chan_sip instance, placed an inbound call from it, confirmed matched using line parameter.
> 
> 
> Thanks,
> 
> Joshua Colp
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140930/212317ee/attachment-0001.html>