[asterisk-dev] [Code Review] 4019: PJSIP: Handle defaults properly

[Mark Michelson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4019/#review13413
-----------------------------------------------------------

Ship it!


Ship It!

- Mark Michelson


On Sept. 24, 2014, 1:03 p.m., opticron wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/4019/
> -----------------------------------------------------------
> 
> (Updated Sept. 24, 2014, 1:03 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> This updates the code behind PJSIP configuration options with custom handlers to deal with the assigned default values properly where it makes sense and adjusting the default value where it doesn't. Before applying this patch, there were several cases where the default value for an option would prevent that config section from loading properly.
> 
> 
> Diffs
> -----
> 
>   branches/12/res/res_pjsip_endpoint_identifier_ip.c 423656 
>   branches/12/res/res_pjsip/pjsip_configuration.c 423656 
>   branches/12/res/res_pjsip/location.c 423656 
>   branches/12/res/res_pjsip/config_transport.c 423656 
>   branches/12/configs/pjsip.conf.sample 423656 
> 
> Diff: https://reviewboard.asterisk.org/r/4019/diff/
> 
> 
> Testing
> -------
> 
> Ensured that default values for config options were accepted.
> 
> 
> Thanks,
> 
> opticron
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140930/f99194c9/attachment.html>