[asterisk-dev] [Code Review] 4032: PJSIP: Force transport on contact rewrite

[Mark Michelson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4032/#review13405
-----------------------------------------------------------

Ship it!



branches/12/res/res_pjsip_nat.c
<https://reviewboard.asterisk.org/r/4032/#comment23892>

    Just set uri->transport_param.slen = 0 instead of creating the empty_string constant.


- Mark Michelson


On Sept. 30, 2014, 12:19 p.m., opticron wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/4032/
> -----------------------------------------------------------
> 
> (Updated Sept. 30, 2014, 12:19 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> If contact rewriting is enabled but the contact differs in transport from what is actually being used, messages after the initial INVITE transaction can be sent to an incorrect transport/port combination. In the case where this bug occurred the remote party never received a BYE since it was sent to the remote party's TCP port over UDP.
> 
> 
> Diffs
> -----
> 
>   branches/12/res/res_pjsip_nat.c 424094 
> 
> Diff: https://reviewboard.asterisk.org/r/4032/diff/
> 
> 
> Testing
> -------
> 
> Ensured that this patch allowed the BYE to be sent properly.
> 
> 
> Thanks,
> 
> opticron
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140930/f28d2f10/attachment.html>