[asterisk-dev] [Code Review] 4031: Realtime peers are never unref: memory leaks

[wdoekes]

> On Sept. 29, 2014, 3:16 p.m., wdoekes wrote:
> > Did you check the behaviour in 1.8?
> 
> ibercom wrote:
>     The same. Although in 1.8 the leaks are less.
>     
>     I run the same patch in both.
>

Very well. Then please put the lowest living asterisk branch where the
problem is in the branch-field (1.8 in this case). Code changes are
propagated upwards in the Asterisk commit scheme.

And update the patch, removing the line instead of commenting it out.


- wdoekes


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4031/#review13396
-----------------------------------------------------------


On Sept. 29, 2014, 2:42 p.m., ibercom wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/4031/
> -----------------------------------------------------------
> 
> (Updated Sept. 29, 2014, 2:42 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Bugs: ASTERISK-22945
>     https://issues.asterisk.org/jira/browse/ASTERISK-22945
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> The sip_poke_peer() function is called four times in chan_sip.c and all of them are different. With this change the realtime peers are unreferenced correctly.
> 
> 
> Diffs
> -----
> 
>   http://svn.asterisk.org/svn/asterisk/branches/11/channels/chan_sip.c 424094 
> 
> Diff: https://reviewboard.asterisk.org/r/4031/diff/
> 
> 
> Testing
> -------
> 
> Asterisk is working fine for two weeks without problems.
> 
> 
> Thanks,
> 
> ibercom
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140929/02923dfb/attachment.html>