[asterisk-dev] [Code Review] 4023: Allow passing options and command to MixMonitor when recording in ConfBridge

[gareth]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4023/
-----------------------------------------------------------

(Updated Sept. 27, 2014, 6:30 a.m.)


Review request for Asterisk Developers.


Changes
-------

Updated patch to address Corey's comments.

CONFBRIDGE() is now registered as an escalating write function.


Bugs: ASTERISK-24351
    https://issues.asterisk.org/jira/browse/ASTERISK-24351


Repository: Asterisk


Description
-------

This patch adds the ability to pass options and a command to MixMontor when recording a conference using ConfBridge.

New options are -

record_options: Options to MixMontor, eg: m(), W() etc.
record_command: The command to execute when recording is over.

eg: Set(CONFBRIDGE(bridge,record_command)=/path/to/command ^{MIXMONITOR_FILENAME}))

Note:

The current behavior of set_rec_filename is to always append a timestamp to rec_file. This is desirable for dynamically generated rec_file, but doesn't make sense for a user-supplied rec_file and the documenation does not mention that it does this either.

So the patch changes set_rec_filename to use the user-supplied rec_file as-is. 


Diffs (updated)
-----

  /trunk/configs/samples/confbridge.conf.sample 424055 
  /trunk/apps/confbridge/include/confbridge.h 424055 
  /trunk/apps/confbridge/conf_config_parser.c 424055 
  /trunk/apps/app_confbridge.c 424055 

Diff: https://reviewboard.asterisk.org/r/4023/diff/


Testing
-------

Set record_options to m(${MAILBOX}) and verified that a recording was delivered to ${MAILBOX}.

Set record_command to /bin/rm ^{MIXMONITOR_FILENAME} and checked that recording was deleted on ending the conference.


Thanks,

gareth

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140927/d9f35c68/attachment.html>