[asterisk-dev] [Code Review] 4012: testsuite: Allow multiple -t options to be passed.
Corey Farrell
reviewboard at asterisk.org
Fri Sep 26 08:18:13 CDT 2014
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4012/#review13386
-----------------------------------------------------------
I like this, something I had wished for in the past but never got around to implementing.
/asterisk/trunk/runtests.py
<https://reviewboard.asterisk.org/r/4012/#comment23882>
Shouldn't instead check that test_suite.tests has length > 1? My feeling is that the "TEST RESULTS" summary should be outputted any time more than 1 test was requested to run. This would include situations where -t is specified multiple times, or for '-t channels'.
I realize this was an issue in the past (for example when using -t channels/), but might as well fix while you're here.
- Corey Farrell
On Sept. 22, 2014, 5:01 a.m., wdoekes wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/4012/
> -----------------------------------------------------------
>
> (Updated Sept. 22, 2014, 5:01 a.m.)
>
>
> Review request for Asterisk Developers.
>
>
> Repository: testsuite
>
>
> Description
> -------
>
> Allow -t to be specified more than once.
>
> Also cleaned up runtests.py a bit.
>
>
> Diffs
> -----
>
> /asterisk/trunk/runtests.py 5632
>
> Diff: https://reviewboard.asterisk.org/r/4012/diff/
>
>
> Testing
> -------
>
> Yes.
>
>
> Thanks,
>
> wdoekes
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140926/6a6af956/attachment.html>
More information about the asterisk-dev
mailing list