[asterisk-dev] Opinions Needed: Case sensitivity in config file section names

[Paul Belanger]

On Tue, Sep 23, 2014 at 1:47 PM, George Joseph
<george.joseph at fairview5.com> wrote:
> On Tue, Sep 23, 2014 at 11:13 AM, Matthew Jordan <mjordan at digium.com> wrote:
>>
>>
>>
>> On Tue, Sep 23, 2014 at 11:29 AM, Paul Belanger
>> <paul.belanger at polybeacon.com> wrote:
>>>
>>> On Tue, Sep 23, 2014 at 11:45 AM, George Joseph
>>> <george.joseph at fairview5.com> wrote:
>>> > I've been working on some changes for config.c and in the process I've
>>> > found
>>> > 5 instances of someone attempting to do "cat->name == category_name"
>>> > instead
>>> > of "strcmp(cat->name, category_name)".    Example:
>>> >
>
> <snip>
>>>
>>> > My question is...  Should I fix these so the case sensitive match works
>>> > and
>>> > runs first or just remove the first loop so the match is always
>>> > case-insensitive?   I'm hoping the latter not only because it makes the
>>> > code
>>> > simpler but because that's how it's worked for years and suddenly
>>> > making the
>>> > match case sensitive might cause unexpected problems.
>>> >
>>> > Thoughts?
>>> >
>>> For me, case sensitive.  Because I config files that do have:
>>>
>>> [Foo]
>>>
>>> [foo]
>>>
>>> [fOO]
>>>
>>> don't ask, long story.
>>>
>>
>
> Which file?  I'd like to test a before and after scenario to make sure
> whatever I change still works.
>
My example was chan_sip, we mostly use MAC address for categories.
I'd have to review my notes, but I actually think there is a bug
(which you'll likely tell me), if you change the case of the category
and reload chan_sip, asterisk does not detect the change.  You have
stop / start asterisk.

>>
>> And it currently works? :-D
>>
>> (Just kidding)
>>
>> If that is the case, then obviously any change we make here should be done
>> to trunk only.
>>
>> I'll leave the impending case-war to others... :-)
>>
>
> Ok, I think I'll fix the ones that are definitely broken so they do case
> sensitive first then fall back to case insensitive.   That should preserve
> the current behavior.
>
>
> --
> _____________________________________________________________________
> -- Bandwidth and Colocation Provided by http://www.api-digital.com --
>
> asterisk-dev mailing list
> To UNSUBSCRIBE or update options visit:
>    http://lists.digium.com/mailman/listinfo/asterisk-dev



-- 
Paul Belanger | PolyBeacon, Inc.
Jabber: paul.belanger at polybeacon.com | IRC: pabelanger (Freenode)
Github: https://github.com/pabelanger | Twitter: https://twitter.com/pabelanger