[asterisk-dev] [Code Review] 4013: Alembic: Add 'outgoing' enum value to sippeers directmedia enumerator

[Jonathan Rose]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4013/
-----------------------------------------------------------

(Updated Sept. 23, 2014, 10:41 a.m.)


Review request for Asterisk Developers and Matt Jordan.


Changes
-------

Hey hey, so instead of dropping the tables I was able to do a safe altering of the tables by doing some postgres specific shenanigans. I've also made sure it works against mysql.
Basically, going forward everything is fine.  Going backwards, we change any instances of 'outgoing' in the table to NULL prior to changing the type.


Bugs: ASTERISK-23781
    https://issues.asterisk.org/jira/browse/ASTERISK-23781


Repository: Asterisk


Description
-------

The SIP directmedia value 'outgoing' was overlooked when creating the table and needs to be added. Unfortunately this means dropping the column and rebuilding it with a new enum.


Diffs (updated)
-----

  /branches/12/contrib/ast-db-manage/config/versions/10aedae86a32_add_outgoing_enum_va.py PRE-CREATION 

Diff: https://reviewboard.asterisk.org/r/4013/diff/


Testing
-------

upgraded, checked to see if I could put 'outgoing' in the directmedia column. Downgraded, upgraded again to make sure things didn't explode.

All on a postgres database


Thanks,

Jonathan Rose

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140923/531a7db2/attachment.html>