[asterisk-dev] [Code Review] 4016: chan_sip: Unref outbound proxy structure on dialog(pvt) struct

[Joshua Colp]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4016/#review13379
-----------------------------------------------------------



/branches/1.8/channels/chan_sip.c
<https://reviewboard.asterisk.org/r/4016/#comment23871>

    This is actually incorrect. p->outboundproxy may point to a statically allocated outbound proxy. To ensure both cases are met use ref_proxy to set it to NULL. This will unref if it should and otherwise not unref.


- Joshua Colp


On Sept. 22, 2014, 8:30 p.m., wdoekes wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/4016/
> -----------------------------------------------------------
> 
> (Updated Sept. 22, 2014, 8:30 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Bugs: ASTERISK-24063
>     https://issues.asterisk.org/jira/browse/ASTERISK-24063
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> In ASTERISK-24063 Damian Ivereigh wants to add outboundproxy support
> to OPTIONS qualify requests.
> 
> The addition clearly shows that dialog-set proxies were not unreffed,
> creating a (very slow) memory leak if proxies are frequently changed.
> 
> This should fix things.
> 
> 
> Diffs
> -----
> 
>   /branches/1.8/channels/chan_sip.c 423724 
> 
> Diff: https://reviewboard.asterisk.org/r/4016/diff/
> 
> 
> Testing
> -------
> 
> Tested with the patch from:
> https://reviewboard.asterisk.org/r/3948/
> because that patch makes sure a proxy is reffed for every OPTIONS.
> But without that patch, the problem applies to most other dialog
> creation as well (calling, mwi, ...).
> 
> sip.conf:
> 
> [general]
> 
> [whoever]
> type=peer
> host=127.0.0.1
> port=5062
> qualify=yes
> outboundproxy=127.0.0.1:5065
> 
> 
> Without this patch, 'memory atexit list' listed proxy_from_config(),
> with this patch, the atexit list was free of any chan_sip related stuff.
> 
> 
> Thanks,
> 
> wdoekes
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140923/86fca36c/attachment-0001.html>