[asterisk-dev] [Code Review] 4006: Test to validate 503 not generated on INVITE retransmissions

wdoekes reviewboard at asterisk.org
Mon Sep 22 14:41:19 CDT 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4006/#review13375
-----------------------------------------------------------

Ship it!


> I've managed to force the re-transmit and drop the grep... however
> I didn't succeed at getting rid of the test-run script (my test
> suite dumped alot of errors when tried that)
> Could you do the last step of the adaptation?

Yes. Turns out we required the grep after all. It seemed impossible
to make the scenario stop after a single retransmit, and believe me
I've tried.

Thanks. It has been shipped.

- wdoekes


On Sept. 22, 2014, 7:38 p.m., Torrey Searle wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/4006/
> -----------------------------------------------------------
> 
> (Updated Sept. 22, 2014, 7:38 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Bugs: ASTERISK-24335
>     https://issues.asterisk.org/jira/browse/ASTERISK-24335
> 
> 
> Repository: testsuite
> 
> 
> Description
> -------
> 
> This is a test for the test suite to reproduce the issue described in ASTERISK-24335
> 
> 
> Diffs
> -----
> 
>   /asterisk/trunk/tests/channels/SIP/tests.yaml 5632 
>   /asterisk/trunk/tests/channels/SIP/invite_retransmit/test-config.yaml PRE-CREATION 
>   /asterisk/trunk/tests/channels/SIP/invite_retransmit/sipp/A_PARTY.xml PRE-CREATION 
>   /asterisk/trunk/tests/channels/SIP/invite_retransmit/run-test PRE-CREATION 
>   /asterisk/trunk/tests/channels/SIP/invite_retransmit/configs/ast1/sip.conf PRE-CREATION 
>   /asterisk/trunk/tests/channels/SIP/invite_retransmit/configs/ast1/extensions.conf PRE-CREATION 
> 
> Diff: https://reviewboard.asterisk.org/r/4006/diff/
> 
> 
> Testing
> -------
> 
> test passes when 4003 patch applied, fails when patch not applied
> 
> 
> Thanks,
> 
> Torrey Searle
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140922/53377a0f/attachment.html>


More information about the asterisk-dev mailing list