[asterisk-dev] [Code Review] 3972: Only install dahdi_span_config_hook if DAHDI is enabled

Corey Farrell reviewboard at asterisk.org
Wed Sep 17 05:12:47 CDT 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3972/#review13319
-----------------------------------------------------------

Ship it!


Ship It!

- Corey Farrell


On Sept. 4, 2014, 2:35 p.m., David Lee wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/3972/
> -----------------------------------------------------------
> 
> (Updated Sept. 4, 2014, 2:35 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> I'm a bit weird, and I configure asterisk with --prefix=/opt/asterisk,
> so that I can install it without running as root. The install script
> for the DAHDI hook scripts were hard coded to install into /usr/share,
> which foils my weirdness.
> 
> This patch changes the install to only install the hook script if
> DAHDI is enabled. It also adds the script to the uninstall task, and
> moves the DAHDI_UDEV_HOOK_DIR variable so that it's not between the
> _MAKEOPTS variables and their comment.
> 
> 
> Diffs
> -----
> 
>   /branches/13/makeopts.in 422582 
>   /branches/13/Makefile 422582 
> 
> Diff: https://reviewboard.asterisk.org/r/3972/diff/
> 
> 
> Testing
> -------
> 
> Ran ./configure && make all install both with and without DAHDI,
> confirming that it worked as expected.
> 
> 
> Thanks,
> 
> David Lee
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140917/a55cabcc/attachment.html>


More information about the asterisk-dev mailing list