[asterisk-dev] [Code Review] 3996: Fix zero duration vm description when using MixMonitor m option

Scott Griepentrog reviewboard at asterisk.org
Mon Sep 15 16:37:11 CDT 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3996/
-----------------------------------------------------------

(Updated Sept. 15, 2014, 4:37 p.m.)


Review request for Asterisk Developers.


Changes
-------

Updated issue #


Bugs: ASTERISK-24328
    https://issues.asterisk.org/jira/browse/ASTERISK-24328


Repository: Asterisk


Description
-------

Changes during format improvements resulted in the recording to voicemail option 'm' of MixMonitor() app storing voicemail msgXXXX.txt files with a zero description due to a failed lookup of the file format.  This change introduces utility function ast_ratestream() to obtain the underlying format's ast_format_get_sample_rate() and a fix to the app_voicemail implementation of msg_create_from_file (mapped from call to ast_app_copy_recording_to_vm) to use it to obtain the correct sample rate for the storage format being used.


Diffs
-----

  /branches/13/main/file.c 423149 
  /branches/13/include/asterisk/file.h 423149 
  /branches/13/apps/app_voicemail.c 423149 

Diff: https://reviewboard.asterisk.org/r/3996/diff/


Testing
-------


Thanks,

Scott Griepentrog

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140915/732de86a/attachment.html>


More information about the asterisk-dev mailing list