[asterisk-dev] [Code Review] 3988: res_pjsip: Don't require a password when doing userpass authentication

Sean Bright reviewboard at asterisk.org
Mon Sep 15 14:27:05 CDT 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3988/
-----------------------------------------------------------

(Updated Sept. 15, 2014, 7:27 p.m.)


Review request for Asterisk Developers.


Repository: Asterisk


Description
-------

An empty password is valid for username/password authentication so we shouldn't barf on it.


Diffs
-----

  /branches/12/res/res_pjsip/config_auth.c 422963 

Diff: https://reviewboard.asterisk.org/r/3988/diff/


Testing (updated)
-------

Compiles.  Registered a device with auth_type=userpass and no password set.  Tested registration with a password which failed, and again without a password (an empty password) and it succeeds.


Thanks,

Sean Bright

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140915/c259baf0/attachment.html>


More information about the asterisk-dev mailing list