[asterisk-dev] [Code Review] 3984: Module to add devstate for MWI.

[Mark Michelson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3984/#review13293
-----------------------------------------------------------

Ship it!


Aside from what Matt had to say, this looks good by me.

- Mark Michelson


On Sept. 8, 2014, 6:21 p.m., Jason Parker wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/3984/
> -----------------------------------------------------------
> 
> (Updated Sept. 8, 2014, 6:21 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> Add a device state for MWI.  This allows for a blinky light when a mailbox has at least 1 new message.
> 
> 
> Diffs
> -----
> 
>   branches/12/res/res_mwi_devstate.c PRE-CREATION 
> 
> Diff: https://reviewboard.asterisk.org/r/3984/diff/
> 
> 
> Testing
> -------
> 
> Leaving a voicemail then deleting that voicemail causes the hint to go to IN_USE then to NOT_INUSE.  Polled mailboxes do not appear to update, but I can't tell whether that's a failing of pollmailboxes or not.
> 
> Patch also applies to and functions on branches/13/.
> 
> 
> Thanks,
> 
> Jason Parker
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140912/0ca914af/attachment.html>