[asterisk-dev] [Code Review] 3988: res_pjsip: Don't require a password when doing userpass authentication

Joshua Colp reviewboard at asterisk.org
Wed Sep 10 13:25:34 CDT 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3988/#review13278
-----------------------------------------------------------



/branches/12/res/res_pjsip/config_auth.c
<https://reviewboard.asterisk.org/r/3988/#comment23764>

    Test this and make sure that the PJSIP digest authentication doesn't freak. :P


- Joshua Colp


On Sept. 10, 2014, 5:53 p.m., Sean Bright wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/3988/
> -----------------------------------------------------------
> 
> (Updated Sept. 10, 2014, 5:53 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> An empty password is valid for username/password authentication so we shouldn't barf on it.
> 
> 
> Diffs
> -----
> 
>   /branches/12/res/res_pjsip/config_auth.c 422963 
> 
> Diff: https://reviewboard.asterisk.org/r/3988/diff/
> 
> 
> Testing
> -------
> 
> Compiles.
> 
> 
> Thanks,
> 
> Sean Bright
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140910/032c037d/attachment.html>


More information about the asterisk-dev mailing list