[asterisk-dev] [Code Review] 3981: chan_rtp: Add unicast RTP support to chan_multicast_rtp.

[Mark Michelson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3981/#review13260
-----------------------------------------------------------

Ship it!



/trunk/channels/chan_rtp.c
<https://reviewboard.asterisk.org/r/3981/#comment23734>

    Should this also call ast_rtp_instance_stop() before ast_rtp_instance_destroy()?


- Mark Michelson


On Sept. 7, 2014, 3:07 p.m., Joshua Colp wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/3981/
> -----------------------------------------------------------
> 
> (Updated Sept. 7, 2014, 3:07 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> The chan_multicast_rtp module currently allows sending an RTP stream as multicast but not unicast. Using unicast allows the channel to become a thin protocol-less transport mechanism for media. To that end I've added unicast RTP support and moved both into a single channel driver (chan_rtp) as they shared most of the code. Cleanup of some code also occurred.
> 
> 
> Diffs
> -----
> 
>   /trunk/channels/chan_rtp.c PRE-CREATION 
>   /trunk/channels/chan_multicast_rtp.c 422835 
> 
> Diff: https://reviewboard.asterisk.org/r/3981/diff/
> 
> 
> Testing
> -------
> 
> Originated a call to a UnicastRTP channel and sent it to a Playback. Confirmed that RTP was sent to the provided IP address/port with the given format.
> 
> 
> Thanks,
> 
> Joshua Colp
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140908/af8d41fe/attachment.html>