[asterisk-dev] [Code Review] 3924: Testsuite: Add modular event action framework

[opticron]

> On Sept. 5, 2014, 4:40 p.m., Scott Griepentrog wrote:
> > I'm getting errors with this patch running certain manager tests such as mixmonitor.  They don't happen without the patch on the same machine.
> > 
> > --> Running test 'tests/manager/mixmonitor' ...
> > Making sure Asterisk isn't running ...
> > Making sure SIPp isn't running...
> > Running ['./lib/python/asterisk/test_runner.py', 'tests/manager/mixmonitor'] ...
> > Traceback (most recent call last):
> >   File "./lib/python/asterisk/test_runner.py", line 319, in <module>
> >     sys.exit(main() or 0)
> >   File "./lib/python/asterisk/test_runner.py", line 305, in main
> >     load_test_modules(test_config, test_object, ast_version)
> >   File "./lib/python/asterisk/test_runner.py", line 120, in load_test_modules
> >     module_type = load_and_parse_module(module_spec['typename'])
> >   File "./lib/python/asterisk/test_runner.py", line 176, in load_and_parse_module
> >     module = __import__(module_name)
> >   File "/home/sgriepentrog/rb3924/testsuite-patched/lib/python/asterisk/ami.py", line 16, in <module>
> >     import pluggable_modules
> >   File "/home/sgriepentrog/rb3924/testsuite-patched/lib/python/asterisk/pluggable_modules.py", line 17, in <module>
> >     from ami import AMIEventInstance
> > ImportError: cannot import name AMIEventInstance
> > Exception occurred while archiving logs from /tmp/asterisk-testsuite/manager/mixmonitor/run_1/ast1/var/log/asterisk to ./logs/manager/mixmonitor/run_1/ast1/var/log/asterisk: [Errno 2] No such file or directory
> > Test ['./lib/python/asterisk/test_runner.py', 'tests/manager/mixmonitor', 'SVN-trunk-r422647'] failed
> >

I seem to have created an import loop. I'll break out things causing this.


- opticron


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3924/#review13258
-----------------------------------------------------------


On Aug. 19, 2014, 9:32 p.m., opticron wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/3924/
> -----------------------------------------------------------
> 
> (Updated Aug. 19, 2014, 9:32 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Repository: testsuite
> 
> 
> Description
> -------
> 
> This adds a modular event/action system that can handle routing from arbitrary events to arbitrary actions allowing creation of more flexible tests. This includes event modules for AMI and ARI actions as well as action modules for AMI, ARI, callbacks, and more.
> 
> This also converts three tests as a proof of concept.
> 
> 
> Diffs
> -----
> 
>   asterisk/trunk/tests/rest_api/bridges/bridge_by_id/test-config.yaml 5409 
>   asterisk/trunk/tests/rest_api/bridges/attended_transfer/test-config.yaml 5409 
>   asterisk/trunk/tests/rest_api/bridges/attended_transfer/attended_transfer.py 5409 
>   asterisk/trunk/tests/asyncagi/asyncagi_break/test-config.yaml 5409 
>   asterisk/trunk/tests/asyncagi/asyncagi_break/asyncagi_break.py 5409 
>   asterisk/trunk/lib/python/asterisk/pluggable_registry.py PRE-CREATION 
>   asterisk/trunk/lib/python/asterisk/pluggable_modules.py 5409 
>   asterisk/trunk/lib/python/asterisk/ari.py 5409 
>   asterisk/trunk/lib/python/asterisk/ami.py 5409 
> 
> Diff: https://reviewboard.asterisk.org/r/3924/diff/
> 
> 
> Testing
> -------
> 
> Ran the tests and verified that events and actions were triggering properly.
> 
> 
> Thanks,
> 
> opticron
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140908/2618f437/attachment.html>