[asterisk-dev] [Code Review] 3960: res_pjsip_pubsub: Check supported headers for eventlist before allowing subscribe to resource list

[Matt Jordan]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3960/#review13256
-----------------------------------------------------------

Ship it!



/branches/13/res/res_pjsip_pubsub.c
<https://reviewboard.asterisk.org/r/3960/#comment23732>

    Extraneous white space change - this should probably be removed.


- Matt Jordan


On Aug. 28, 2014, 5:55 p.m., Jonathan Rose wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/3960/
> -----------------------------------------------------------
> 
> (Updated Aug. 28, 2014, 5:55 p.m.)
> 
> 
> Review request for Asterisk Developers and Mark Michelson.
> 
> 
> Bugs: ASTERISK-23871
>     https://issues.asterisk.org/jira/browse/ASTERISK-23871
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> https://wiki.asterisk.org/wiki/display/AST/Resource+List+Subscription+Test+Plan
> 
> According to the off-nominal plan, if eventlist support is indicated in a subscribe's Supported header(s), subscriptions to a resource list should fail with a 421 extension not supported. This wasn't currently happening since the Supported header isn't actually checked by anything in the res_pjsip_pubsub code, so this patch adds a check for it.
> 
> 
> Diffs
> -----
> 
>   /branches/13/res/res_pjsip_pubsub.c 422272 
> 
> Diff: https://reviewboard.asterisk.org/r/3960/diff/
> 
> 
> Testing
> -------
> 
> Ran nominal RLS tests, ran in development off-nominal RLS tests, and ran Presence and MWI PJSIP subscription tests to confirm that they didn't break.
> 
> 
> Thanks,
> 
> Jonathan Rose
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140905/b68a32db/attachment-0001.html>