[asterisk-dev] [Code Review] 3961: Testsuite: Off-nominal resource list subscription tests (Lists only, no lists of lists)

[Jonathan Rose]

> On Sept. 4, 2014, 10:56 a.m., opticron wrote:
> > /asterisk/trunk/tests/channels/pjsip/subscriptions/rls/lists/off_nominal/mwi/subscribe_wrong_event_header/test-config.yaml, line 23
> > <https://reviewboard.asterisk.org/r/3961/diff/1/?file=66944#file66944line23>
> >
> >     Idem.
> 
> Jonathan Rose wrote:
>     Got these plus a bunch that you didn't mention.

EDIT:  Hmmm, I might have been overzealous on this.


- Jonathan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3961/#review13232
-----------------------------------------------------------


On Aug. 28, 2014, 6:06 p.m., Jonathan Rose wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/3961/
> -----------------------------------------------------------
> 
> (Updated Aug. 28, 2014, 6:06 p.m.)
> 
> 
> Review request for Asterisk Developers and Mark Michelson.
> 
> 
> Bugs: ASTERISK-23871
>     https://issues.asterisk.org/jira/browse/ASTERISK-23871
> 
> 
> Repository: testsuite
> 
> 
> Description
> -------
> 
> https://wiki.asterisk.org/wiki/display/AST/Resource+List+Subscription+Test+Plan
> 
> Reality has led to some deviations from the drafted testplan. Of note:
> 
> Test 1: Lack of a supported header now yields 404 instead of 421
> Test 2: external MWI doesn't assume the existence of a resource, instead it is based on whether there is a pjsip aor that matches the name -- this leads to MWI tests that are rather similar to presence tests
> Test 4: This produces a 500 error instead of a 404
> 
> In addition, Test requires https://reviewboard.asterisk.org/r/3960/
> since previously the Supported headers weren't being checked
> 
> 
> Diffs
> -----
> 
>   /asterisk/trunk/tests/channels/pjsip/subscriptions/rls/lists/off_nominal/tests.yaml PRE-CREATION 
>   /asterisk/trunk/tests/channels/pjsip/subscriptions/rls/lists/off_nominal/presence/tests.yaml PRE-CREATION 
>   /asterisk/trunk/tests/channels/pjsip/subscriptions/rls/lists/off_nominal/presence/subscribe_wrong_event_header/test-config.yaml PRE-CREATION 
>   /asterisk/trunk/tests/channels/pjsip/subscriptions/rls/lists/off_nominal/presence/subscribe_wrong_event_header/sipp/list_subscribe.xml PRE-CREATION 
>   /asterisk/trunk/tests/channels/pjsip/subscriptions/rls/lists/off_nominal/presence/subscribe_wrong_event_header/configs/ast1/pjsip.conf PRE-CREATION 
>   /asterisk/trunk/tests/channels/pjsip/subscriptions/rls/lists/off_nominal/presence/subscribe_wrong_event_header/configs/ast1/extensions.conf PRE-CREATION 
>   /asterisk/trunk/tests/channels/pjsip/subscriptions/rls/lists/off_nominal/presence/subscribe_wo_eventlist_support/test-config.yaml PRE-CREATION 
>   /asterisk/trunk/tests/channels/pjsip/subscriptions/rls/lists/off_nominal/presence/subscribe_wo_eventlist_support/sipp/list_subscribe.xml PRE-CREATION 
>   /asterisk/trunk/tests/channels/pjsip/subscriptions/rls/lists/off_nominal/presence/subscribe_wo_eventlist_support/configs/ast1/pjsip.conf PRE-CREATION 
>   /asterisk/trunk/tests/channels/pjsip/subscriptions/rls/lists/off_nominal/presence/subscribe_wo_eventlist_support/configs/ast1/extensions.conf PRE-CREATION 
>   /asterisk/trunk/tests/channels/pjsip/subscriptions/rls/lists/off_nominal/presence/some_list_resources_exist/test-config.yaml PRE-CREATION 
>   /asterisk/trunk/tests/channels/pjsip/subscriptions/rls/lists/off_nominal/presence/some_list_resources_exist/sipp/list_subscribe.xml PRE-CREATION 
>   /asterisk/trunk/tests/channels/pjsip/subscriptions/rls/lists/off_nominal/presence/some_list_resources_exist/configs/ast1/pjsip.conf PRE-CREATION 
>   /asterisk/trunk/tests/channels/pjsip/subscriptions/rls/lists/off_nominal/presence/some_list_resources_exist/configs/ast1/extensions.conf PRE-CREATION 
>   /asterisk/trunk/tests/channels/pjsip/subscriptions/rls/lists/off_nominal/presence/resource_duplication/test-config.yaml PRE-CREATION 
>   /asterisk/trunk/tests/channels/pjsip/subscriptions/rls/lists/off_nominal/presence/resource_duplication/sipp/list_subscribe.xml PRE-CREATION 
>   /asterisk/trunk/tests/channels/pjsip/subscriptions/rls/lists/off_nominal/presence/resource_duplication/configs/ast1/pjsip.conf PRE-CREATION 
>   /asterisk/trunk/tests/channels/pjsip/subscriptions/rls/lists/off_nominal/presence/resource_duplication/configs/ast1/extensions.conf PRE-CREATION 
>   /asterisk/trunk/tests/channels/pjsip/subscriptions/rls/lists/off_nominal/presence/no_list_resources_exist/test-config.yaml PRE-CREATION 
>   /asterisk/trunk/tests/channels/pjsip/subscriptions/rls/lists/off_nominal/presence/no_list_resources_exist/sipp/list_subscribe.xml PRE-CREATION 
>   /asterisk/trunk/tests/channels/pjsip/subscriptions/rls/lists/off_nominal/presence/no_list_resources_exist/configs/ast1/pjsip.conf PRE-CREATION 
>   /asterisk/trunk/tests/channels/pjsip/subscriptions/rls/lists/off_nominal/presence/list_does_not_exist/test-config.yaml PRE-CREATION 
>   /asterisk/trunk/tests/channels/pjsip/subscriptions/rls/lists/off_nominal/presence/list_does_not_exist/sipp/list_subscribe.xml PRE-CREATION 
>   /asterisk/trunk/tests/channels/pjsip/subscriptions/rls/lists/off_nominal/presence/list_does_not_exist/configs/ast1/pjsip.conf PRE-CREATION 
>   /asterisk/trunk/tests/channels/pjsip/subscriptions/rls/lists/off_nominal/presence/list_does_not_exist/configs/ast1/extensions.conf PRE-CREATION 
>   /asterisk/trunk/tests/channels/pjsip/subscriptions/rls/lists/off_nominal/mwi/tests.yaml PRE-CREATION 
>   /asterisk/trunk/tests/channels/pjsip/subscriptions/rls/lists/off_nominal/mwi/subscribe_wrong_event_header/test-config.yaml PRE-CREATION 
>   /asterisk/trunk/tests/channels/pjsip/subscriptions/rls/lists/off_nominal/mwi/subscribe_wrong_event_header/sipp/list_subscribe.xml PRE-CREATION 
>   /asterisk/trunk/tests/channels/pjsip/subscriptions/rls/lists/off_nominal/mwi/subscribe_wrong_event_header/configs/ast1/pjsip.conf PRE-CREATION 
>   /asterisk/trunk/tests/channels/pjsip/subscriptions/rls/lists/off_nominal/mwi/subscribe_wrong_event_header/configs/ast1/extensions.conf PRE-CREATION 
>   /asterisk/trunk/tests/channels/pjsip/subscriptions/rls/lists/off_nominal/mwi/subscribe_wo_eventlist_support/test-config.yaml PRE-CREATION 
>   /asterisk/trunk/tests/channels/pjsip/subscriptions/rls/lists/off_nominal/mwi/subscribe_wo_eventlist_support/sipp/list_subscribe.xml PRE-CREATION 
>   /asterisk/trunk/tests/channels/pjsip/subscriptions/rls/lists/off_nominal/mwi/subscribe_wo_eventlist_support/configs/ast1/pjsip.conf PRE-CREATION 
>   /asterisk/trunk/tests/channels/pjsip/subscriptions/rls/lists/off_nominal/mwi/subscribe_wo_eventlist_support/configs/ast1/extensions.conf PRE-CREATION 
>   /asterisk/trunk/tests/channels/pjsip/subscriptions/rls/lists/off_nominal/mwi/some_list_resources_exist/test-config.yaml PRE-CREATION 
>   /asterisk/trunk/tests/channels/pjsip/subscriptions/rls/lists/off_nominal/mwi/some_list_resources_exist/sipp/list_subscribe.xml PRE-CREATION 
>   /asterisk/trunk/tests/channels/pjsip/subscriptions/rls/lists/off_nominal/mwi/some_list_resources_exist/configs/ast1/pjsip.conf PRE-CREATION 
>   /asterisk/trunk/tests/channels/pjsip/subscriptions/rls/lists/off_nominal/mwi/resource_duplication/test-config.yaml PRE-CREATION 
>   /asterisk/trunk/tests/channels/pjsip/subscriptions/rls/lists/off_nominal/mwi/resource_duplication/sipp/list_subscribe.xml PRE-CREATION 
>   /asterisk/trunk/tests/channels/pjsip/subscriptions/rls/lists/off_nominal/mwi/resource_duplication/configs/ast1/pjsip.conf PRE-CREATION 
>   /asterisk/trunk/tests/channels/pjsip/subscriptions/rls/lists/off_nominal/mwi/no_list_resources_exist/test-config.yaml PRE-CREATION 
>   /asterisk/trunk/tests/channels/pjsip/subscriptions/rls/lists/off_nominal/mwi/no_list_resources_exist/sipp/list_subscribe.xml PRE-CREATION 
>   /asterisk/trunk/tests/channels/pjsip/subscriptions/rls/lists/off_nominal/mwi/no_list_resources_exist/configs/ast1/pjsip.conf PRE-CREATION 
>   /asterisk/trunk/tests/channels/pjsip/subscriptions/rls/lists/off_nominal/mwi/list_does_not_exist/test-config.yaml PRE-CREATION 
>   /asterisk/trunk/tests/channels/pjsip/subscriptions/rls/lists/off_nominal/mwi/list_does_not_exist/sipp/list_subscribe.xml PRE-CREATION 
>   /asterisk/trunk/tests/channels/pjsip/subscriptions/rls/lists/off_nominal/mwi/list_does_not_exist/configs/ast1/pjsip.conf PRE-CREATION 
>   /asterisk/trunk/tests/channels/pjsip/subscriptions/rls/lists/off_nominal/mwi/list_does_not_exist/configs/ast1/extensions.conf PRE-CREATION 
> 
> Diff: https://reviewboard.asterisk.org/r/3961/diff/
> 
> 
> Testing
> -------
> 
> Ran the tests, checked SIP messages in and out for correctness.
> Ensured that all nominal RLS tests and a subset of other subscription tests were still passing as intended, with patches that resolve the problems in here in place.
> 
> 
> Thanks,
> 
> Jonathan Rose
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140905/3ba84424/attachment-0001.html>