[asterisk-dev] [Code Review] 3965: testsuite: Test CDRs in a multi-party bridge

opticron reviewboard at asterisk.org
Fri Sep 5 15:53:57 CDT 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3965/#review13253
-----------------------------------------------------------

Ship it!


Except for a couple of missing docstrings and long lines, this looks good to go!

- opticron


On Sept. 1, 2014, 12:19 p.m., Matt Jordan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/3965/
> -----------------------------------------------------------
> 
> (Updated Sept. 1, 2014, 12:19 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Bugs: ASTERISK-24241
>     https://issues.asterisk.org/jira/browse/ASTERISK-24241
> 
> 
> Repository: testsuite
> 
> 
> Description
> -------
> 
> This patch tests CDRs for channels in a multi-party bridge. It reproduces the bug on ASTERISK-24241, and passes with the patch on r3964. The test:
> * Makes 5 Local channels, and adds them to a multi-party bridge via ARI.
> * It then takes channels 0 and 3 and removes from the bridge
> * It then re-adds channels 0 and 3
> * Upon having all 5 channels back in the multi-party bridge, it removes them all, hangs them up, and deletes the bridge.
> 
> The test verifies that the expected CDRs are generated.
> 
> 
> Diffs
> -----
> 
>   /asterisk/trunk/tests/cdr/tests.yaml 5539 
>   /asterisk/trunk/tests/cdr/cdr_bridge_multi/test-config.yaml PRE-CREATION 
>   /asterisk/trunk/tests/cdr/cdr_bridge_multi/configs/ast1/extensions.conf PRE-CREATION 
>   /asterisk/trunk/tests/cdr/cdr_bridge_multi/cdr_bridge_multi.py PRE-CREATION 
> 
> Diff: https://reviewboard.asterisk.org/r/3965/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Matt Jordan
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140905/55e08bd6/attachment-0001.html>


More information about the asterisk-dev mailing list