[asterisk-dev] [Code Review] 3951: Testsuite: Nominal test for Inter-Asterisk MWI SIP publication

[Matt Jordan]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3951/#review13240
-----------------------------------------------------------

Ship it!


I agree that we should have some docstrings, but I do think that can be cleaned up on commit.

- Matt Jordan


On Aug. 27, 2014, 2:20 p.m., Mark Michelson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/3951/
> -----------------------------------------------------------
> 
> (Updated Aug. 27, 2014, 2:20 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Bugs: ASTERISK-24116
>     https://issues.asterisk.org/jira/browse/ASTERISK-24116
> 
> 
> Repository: testsuite
> 
> 
> Description
> -------
> 
> This adds a simple test to ensure that Asterisk publishes MWI details correctly between themselves. Asterisk 1 is fed MWI data via AMI and publishes this data over SIP to Asterisk 2. Asterisk 2 then emits AMI MessageWaiting events, and we check those to ensure their details are what we expect.
> 
> Note, this test uncovered a potential issue with regards to querying for MWI state of remote mailboxes. See issue https://issues.asterisk.org/jira/browse/ASTERISK-24272 for more details about that.
> 
> 
> Diffs
> -----
> 
>   /asterisk/trunk/tests/channels/pjsip/publish/tests.yaml 5490 
>   /asterisk/trunk/tests/channels/pjsip/publish/asterisk_event_mwi/test-config.yaml PRE-CREATION 
>   /asterisk/trunk/tests/channels/pjsip/publish/asterisk_event_mwi/mwi_sender.py PRE-CREATION 
>   /asterisk/trunk/tests/channels/pjsip/publish/asterisk_event_mwi/configs/ast2/pjsip.conf PRE-CREATION 
>   /asterisk/trunk/tests/channels/pjsip/publish/asterisk_event_mwi/configs/ast1/pjsip.conf PRE-CREATION 
> 
> Diff: https://reviewboard.asterisk.org/r/3951/diff/
> 
> 
> Testing
> -------
> 
> The test passes as written. I tried messing with values sent and expected received values to ensure that misconfigurations would fail as well.
> 
> 
> Thanks,
> 
> Mark Michelson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140904/8e6e2c06/attachment.html>