[asterisk-dev] [Code Review] 3957: Update commit_msg.py To Work With A Web Proxy, Follow New Commit Msg Format, Prompt For License

opticron reviewboard at asterisk.org
Wed Sep 3 14:27:10 CDT 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3957/#review13219
-----------------------------------------------------------



/commit_msg.py
<https://reviewboard.asterisk.org/r/3957/#comment23709>

    This reads a bit easier as follows:
    for patch, license in zip(patches, license_list):
        f.write("%s (license %s)\n" % (patch, license))


- opticron


On Aug. 28, 2014, 3:56 p.m., Michael Young wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/3957/
> -----------------------------------------------------------
> 
> (Updated Aug. 28, 2014, 3:56 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Bugs: REP-11
> 
> 
> Repository: Repotools
> 
> 
> Description
> -------
> 
> This patch allows the script to connect to the issue tracker from behind a web proxy in order to get the data it needs to create the commit message template.
> 
> It also updates the commit message template produced to follow the new format for commit messages (#close and #comment).
> 
> The patch also adds a prompt for entering the license number per patch file that has been contributed on the issue, if said patch is part of the commit.
> 
> 
> Diffs
> -----
> 
>   /commit_msg.py 883 
> 
> Diff: https://reviewboard.asterisk.org/r/3957/diff/
> 
> 
> Testing
> -------
> 
> Tested from behind a web proxy and on current development machine.
> 
> 
> Thanks,
> 
> Michael Young
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140903/19eafe33/attachment.html>


More information about the asterisk-dev mailing list