[asterisk-dev] [Code Review] 4137: res_pjsip: Add disable_tcp_switch option.

Mark Michelson reviewboard at asterisk.org
Fri Oct 31 12:03:22 CDT 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4137/#review13648
-----------------------------------------------------------

Ship it!


Ship It!

- Mark Michelson


On Oct. 31, 2014, 12:51 a.m., rmudgett wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/4137/
> -----------------------------------------------------------
> 
> (Updated Oct. 31, 2014, 12:51 a.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> When a packet exceeds the MTU, pjproject will switch from UDP to TCP.  In some circumstances (on some networks), this can cause some issues with messages not getting sent to the correct destination - and can also cause connections to get dropped due to quirks in pjproject deciding to terminate TCP connections with no messages.
> 
> While fixing the routing/messaging issues is important, having a configuration option in Asterisk that tells pjproject to not switch over to TCP would be useful.  That way, if some glitch is discovered on some other network/site, we can at least disable the behavior until a fix is put into place.
> 
> 
> Diffs
> -----
> 
>   /branches/12/res/res_pjsip/config_system.c 426829 
>   /branches/12/res/res_pjsip.c 426829 
>   /branches/12/configs/pjsip.conf.sample 426829 
>   /branches/12/UPGRADE.txt 426829 
> 
> Diff: https://reviewboard.asterisk.org/r/4137/diff/
> 
> 
> Testing
> -------
> 
> Tested the documentation and setting of the new option.
> 
> I'm not sure what system setup is needed to trigger pjproject to try switching from UDP to TCP for this option to prevent.
> 
> 
> Thanks,
> 
> rmudgett
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20141031/3a266d6c/attachment.html>


More information about the asterisk-dev mailing list