[asterisk-dev] [Code Review] 3603: func_jitterbuffer: fix audio failure caused by certain masquerade's

[Corey Farrell]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3603/
-----------------------------------------------------------

(Updated Oct. 30, 2014, 8:06 p.m.)


Review request for Asterisk Developers, Joshua Colp and Matt Jordan.


Changes
-------

Remove fixes for leaks and move them to new review 4128, this way they can be addressed sooner.


Summary (updated)
-----------------

func_jitterbuffer: fix audio failure caused by certain masquerade's


Bugs: ASTERISK-22409
    https://issues.asterisk.org/jira/browse/ASTERISK-22409


Repository: Asterisk


Description (updated)
-------

During masquerade it is possible for the AST_JITTERBUFFER_FD to be cleared (set to -1).  This change adds a check when copying channel fd's to prevent clearing an FD with -1.  This seems to resolve the bad audio quality experienced after the masquerade.  When AST_JITTERBUFFER_FD was set to -1, this prevented the channel from polling that timer.  This caused RTP packets to be received late, and discarded.


Diffs (updated)
-----

  /branches/11/main/channel.c 426593 
  /branches/11/funcs/func_jitterbuffer.c 426593 

Diff: https://reviewboard.asterisk.org/r/3603/diff/


Testing (updated)
-------

Verified the scenario outlined in ASTERISK-22409 no longer experiences audio quality loss.


Thanks,

Corey Farrell

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20141031/27f3c74f/attachment.html>