[asterisk-dev] [Code Review] 4120: res_pjsip_acl: contact ACL permits are being interpreted incorrectly

[Matt Jordan]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4120/#review13627
-----------------------------------------------------------


As an addendum to opticron's Ship It: This needs a test.

- Matt Jordan


On Oct. 28, 2014, 2:45 p.m., Jonathan Rose wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/4120/
> -----------------------------------------------------------
> 
> (Updated Oct. 28, 2014, 2:45 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> In the attempt to skip past the 'contact' part of the variable name before passing it into the acl handler, we have a momentary lapse of sanity and forget that '_allow' isn't 'allow' and ast_append_acl interprets it as another deny.
> 
> 
> Diffs
> -----
> 
>   /branches/12/res/res_pjsip_acl.c 426232 
> 
> Diff: https://reviewboard.asterisk.org/r/4120/diff/
> 
> 
> Testing
> -------
> 
> deny=0.0.0.0/24
> allow=<ip address of a device that tries to register>
> 
> Note that I have to reload pjsip after startup in order for the ACL to work... that seems like a bug surely.  In any event, with the patch the device successfully registers.  Without the patch, the registration is blocked by the ACL.
> 
> 
> Thanks,
> 
> Jonathan Rose
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20141029/897a9280/attachment.html>