[asterisk-dev] [Code Review] 4101: Channel Originate/Continue via ARI support for labels in dialplan is incomplete

[opticron]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4101/#review13624
-----------------------------------------------------------



/trunk/res/ari/resource_channels.c
<https://reviewboard.asterisk.org/r/4101/#comment24137>

    This should be defined within the scope of the if block below.



/trunk/res/ari/resource_channels.c
<https://reviewboard.asterisk.org/r/4101/#comment24138>

    This needs a ast_channel_unref after finding the label.



/trunk/res/ari/resource_channels.c
<https://reviewboard.asterisk.org/r/4101/#comment24135>

    This debug message should be removed in the final version of this patch.



/trunk/res/ari/resource_channels.c
<https://reviewboard.asterisk.org/r/4101/#comment24134>

    This should check for a return of -1 and emit the appropriate error message if the priority of the label can not be found.



/trunk/res/ari/resource_channels.c
<https://reviewboard.asterisk.org/r/4101/#comment24136>

    Same comment about this debug message.



/trunk/res/ari/resource_channels.c
<https://reviewboard.asterisk.org/r/4101/#comment24139>

    Same comment on the debug statements here.


- opticron


On Oct. 21, 2014, 12:50 p.m., greenfieldtech wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/4101/
> -----------------------------------------------------------
> 
> (Updated Oct. 21, 2014, 12:50 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Bugs: ASTERISK-24412
>     https://issues.asterisk.org/jira/browse/ASTERISK-24412
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> This patch changes the current behavior of ARI, to allow channel originate/continue requests to be performed with labels as the priority, not only integer values.
> 
> 
> Diffs
> -----
> 
>   /trunk/rest-api/api-docs/channels.json 425359 
>   /trunk/res/res_ari_channels.c 425359 
>   /trunk/res/ari/resource_channels.c 425359 
>   /trunk/res/ari/resource_channels.h 425359 
> 
> Diff: https://reviewboard.asterisk.org/r/4101/diff/
> 
> 
> Testing
> -------
> 
> Testing was performed by testing the following scenarios:
> 1. Originating a call to a numeric priority - works
> 2. Originating a call to a null priority - works
> 3. Originating a call to a label - works
> 4. Continue a call to a label - not tested yet
> 
> 
> Thanks,
> 
> greenfieldtech
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20141029/c8c4a307/attachment.html>