[asterisk-dev] [Code Review] 4119: pjsip: handle outbound unregister correctly

Kevin Harwell reviewboard at asterisk.org
Wed Oct 29 10:47:22 CDT 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4119/#review13619
-----------------------------------------------------------

Ship it!



/branches/12/res/res_pjsip_outbound_registration.c
<https://reviewboard.asterisk.org/r/4119/#comment24130>

    s/it's/its


- Kevin Harwell


On Oct. 28, 2014, 3:03 p.m., Scott Griepentrog wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/4119/
> -----------------------------------------------------------
> 
> (Updated Oct. 28, 2014, 3:03 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Bugs: ASTERISK-24411
>     https://issues.asterisk.org/jira/browse/ASTERISK-24411
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> Patch from John Bigelow:
> 
> This patch sets the status of the outbound registration to reflect when it has been unregistered. Since the registration is unregistered rather than stopped, the registration schedule remains active as before. The patch also updates the documentation of both the AMI and CLI commands.
> 
> 
> Diffs
> -----
> 
>   /branches/12/res/res_pjsip_outbound_registration.c 426523 
> 
> Diff: https://reviewboard.asterisk.org/r/4119/diff/
> 
> 
> Testing
> -------
> 
> Previously failing test channels/pjsip/registration/outbound/unregister/unauthed now passes.  Other pjsip tests that were passing still pass.
> 
> 
> Thanks,
> 
> Scott Griepentrog
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20141029/3c519c23/attachment.html>


More information about the asterisk-dev mailing list