[asterisk-dev] [Code Review] 4121: testsuite: Close ARI websocket connections before stopping reactor

Matt Jordan reviewboard at asterisk.org
Wed Oct 29 09:47:38 CDT 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4121/#review13617
-----------------------------------------------------------

Ship it!


Ship It!

- Matt Jordan


On Oct. 28, 2014, 4:19 p.m., Corey Farrell wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/4121/
> -----------------------------------------------------------
> 
> (Updated Oct. 28, 2014, 4:19 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Repository: testsuite
> 
> 
> Description
> -------
> 
> All (or most) tests in tests/rest_api leak numerous referenced objects by not closing the ARI websocket connection.
> 
> 
> Diffs
> -----
> 
>   /asterisk/trunk/lib/python/asterisk/ari.py 5796 
> 
> Diff: https://reviewboard.asterisk.org/r/4121/diff/
> 
> 
> Testing
> -------
> 
> Using r4038
> 
> 
> Thanks,
> 
> Corey Farrell
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20141029/513e180d/attachment.html>


More information about the asterisk-dev mailing list