[asterisk-dev] [Code Review] 4122: testsuite: Fix freeze on tests/pbx/dialplan_reload

[wdoekes]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4122/#review13604
-----------------------------------------------------------



/asterisk/trunk/tests/pbx/dialplan_reload/run-test
<https://reviewboard.asterisk.org/r/4122/#comment24117>

    I don't quite see what happens here:
    
    - the test does a 'core restart gracefully' 50 times?
    
    Does that fit in 30 seconds now?
    
    Or.. that is the reset_timeout() below? In that case a little comment somewhere would help, so I wouldn't be surprised when the test runs for longer than 30 seconds and succeeds.



/asterisk/trunk/tests/pbx/dialplan_reload/run-test
<https://reviewboard.asterisk.org/r/4122/#comment24116>

    Is it needed to callLater() instead of just calling it? Applies to the other 0-second callLaters too. You'll defer handling soon enough.
    
    The only other example where I find a "callLater(0," in the testsuite, is broken anyway:
    
        reactor.callLater(0, self.launch_test())  # tests/fastagi/record-file/run-test
    



/asterisk/trunk/tests/pbx/dialplan_reload/run-test
<https://reviewboard.asterisk.org/r/4122/#comment24115>

    "Restarted #%d" % self.count



/asterisk/trunk/tests/pbx/dialplan_reload/run-test
<https://reviewboard.asterisk.org/r/4122/#comment24113>

    Why do we wait (an arbitrary) 3 seconds for this? Can't we call the fullybooted_run immediately?



/asterisk/trunk/tests/pbx/dialplan_reload/run-test
<https://reviewboard.asterisk.org/r/4122/#comment24114>

    "Restarting #%d" % self.count


Lastly: PEP says space after a comma, please.

- wdoekes


On Oct. 28, 2014, 10:20 p.m., Corey Farrell wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/4122/
> -----------------------------------------------------------
> 
> (Updated Oct. 28, 2014, 10:20 p.m.)
> 
> 
> Review request for Asterisk Developers and Scott Griepentrog.
> 
> 
> Repository: testsuite
> 
> 
> Description
> -------
> 
> In some configurations 3 seconds is not enough of a delay before Asterisk is fully booted, preventing "core restart gracefully" from succeeding.  This causes many iterations to be skipped, and in some cases the test never ends.
> 
> Make use of "core waitfullybooted" to delay restarts.  Remove unused global variables workingdir and testdir, add global variable restart_iterations to specify 50 runs.  Decrease reactor_timeout from 300 to 30, use reset_timeout instead.
> 
> 
> Diffs
> -----
> 
>   /asterisk/trunk/tests/pbx/dialplan_reload/run-test 5803 
> 
> Diff: https://reviewboard.asterisk.org/r/4122/diff/
> 
> 
> Testing
> -------
> 
> Yes
> 
> 
> Thanks,
> 
> Corey Farrell
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20141029/7f42e6c4/attachment-0001.html>