[asterisk-dev] [Code Review] 4115: res_fax: fax gateway frames leak

[wdoekes]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4115/#review13596
-----------------------------------------------------------



/branches/11/res/res_fax.c
<https://reviewboard.asterisk.org/r/4115/#comment24112>

    Perhaps cache and reuse the return value of ast_channel_readtrans?



/branches/11/res/res_fax.c
<https://reviewboard.asterisk.org/r/4115/#comment24110>

    Heh. I had to stare at that for a while :)



/branches/11/res/res_fax.c
<https://reviewboard.asterisk.org/r/4115/#comment24111>

    This comments looks redundant/misplaced now.


P.S. This looks like an implicit const-cast. That should really be a `const struct ast_trans_pvt *`.

struct ast_trans_pvt *ast_channel_readtrans(const struct ast_channel *chan)
{
        return chan->readtrans;
}

Then again, that's only one in a long list of functions doing that.



- wdoekes


On Oct. 27, 2014, 11:07 a.m., Corey Farrell wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/4115/
> -----------------------------------------------------------
> 
> (Updated Oct. 27, 2014, 11:07 a.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Bugs: ASTERISK-24457
>     https://issues.asterisk.org/jira/browse/ASTERISK-24457
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> fax_gateway_framehook leaks translated frames.  Over 1.6mb worth of frames is leaked by tests/fax/sip/gateway_g711_t38 by one of the instances of Asterisk.
> 
> 
> Diffs
> -----
> 
>   /branches/11/res/res_fax.c 426232 
> 
> Diff: https://reviewboard.asterisk.org/r/4115/diff/
> 
> 
> Testing
> -------
> 
> Verified tests/fax/sip/gateway_g711_t38 no longer leaks on 11 and 13.
> 
> 
> Thanks,
> 
> Corey Farrell
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20141027/7f402317/attachment-0001.html>