[asterisk-dev] [Code Review] 4112: testsuite: Make tests/fax/pjsip/* depend on chan_pjsip

Corey Farrell reviewboard at asterisk.org
Mon Oct 27 02:41:49 CDT 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4112/
-----------------------------------------------------------

Review request for Asterisk Developers.


Repository: testsuite


Description
-------

PJSIP fax tests are missing dependency on chan_pjsip and res_pjsip_t38, causing them all to fail if Asterisk was compiled without pjproject.

I have not looked into if these tests actually require res_pjsip_t38 (I don't have pjproject on my system).  I added it since all tests have 't38' in the name.


Diffs
-----

  /asterisk/trunk/tests/fax/pjsip/t38/test-config.yaml 5649 
  /asterisk/trunk/tests/fax/pjsip/gateway_t38_g711/test-config.yaml 5649 
  /asterisk/trunk/tests/fax/pjsip/gateway_native_t38/test-config.yaml 5649 
  /asterisk/trunk/tests/fax/pjsip/directmedia_reinvite_t38/test-config.yaml 5649 

Diff: https://reviewboard.asterisk.org/r/4112/diff/


Testing
-------

Verified these tests no longer attempt to run when Asterisk was compiled without pjproject.


Thanks,

Corey Farrell

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20141027/84ab996f/attachment.html>


More information about the asterisk-dev mailing list