[asterisk-dev] [Code Review] 4108: Weak References

[Corey Farrell]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4108/
-----------------------------------------------------------

(Updated Oct. 26, 2014, 7:10 a.m.)


Review request for Asterisk Developers, George Joseph and rmudgett.


Changes
-------

Add support to notify that the real object associated with a weak object are being destroyed.

Tweak ao2_weaken(weakobj) so it returns NULL if the real object associated with weakobj has already been destroyed.


Repository: Asterisk


Description
-------

This implements weak references.  The weak object is a real ao2 with normal reference counting of its own.  The original object is destroyed when the only reference remaining is from the weak object.


Diffs (updated)
-----

  /trunk/tests/test_astobj2_weaken.c PRE-CREATION 
  /trunk/main/astobj2.c 426139 
  /trunk/include/asterisk/astobj2.h 426139 

Diff: https://reviewboard.asterisk.org/r/4108/diff/


Testing
-------

Very little, I'm unsure how to actually test that this cannot race, since any potential for a race would be due to very exact timing.


Thanks,

Corey Farrell

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20141026/befa614f/attachment.html>