[asterisk-dev] [Code Review] 4103: chan_pjsip: Add 'moh_passthrough' option for passing through musiconhold requests.

Joshua Colp reviewboard at asterisk.org
Wed Oct 22 11:06:49 CDT 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4103/
-----------------------------------------------------------

Review request for Asterisk Developers.


Repository: Asterisk


Description
-------

Currently when musiconhold is started or stopped in PJSIP it is always locally generated using res_musiconhold. This change adds an option, moh_passthrough, that allows musiconhold requests to be passed through chan_pjsip. This is done by sending a re-INVITE with recvonly state on the streams when the channel is put on hold and sending a re-INVITE with sendrecv state on the streams when the channel is taken off hold. The end result of this being that an upstream entity (such as another PBX) can generate the musiconhold instead.


Diffs
-----

  /trunk/res/res_pjsip_sdp_rtp.c 426095 
  /trunk/res/res_pjsip/pjsip_configuration.c 426095 
  /trunk/res/res_pjsip.c 426095 
  /trunk/include/asterisk/res_pjsip_session.h 426095 
  /trunk/include/asterisk/res_pjsip.h 426095 
  /trunk/contrib/ast-db-manage/config/versions/339e1dfa644d_add_moh_passthrough_option_to_pjsip.py PRE-CREATION 
  /trunk/channels/pjsip/dialplan_functions.c 426095 
  /trunk/channels/chan_pjsip.c 426095 

Diff: https://reviewboard.asterisk.org/r/4103/diff/


Testing
-------

Enabled option. Placed call to a remote server. Put call on hold and off hold. Confirmed re-INVITEs were sent with proper state.


Thanks,

Joshua Colp

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20141022/6092aadb/attachment.html>


More information about the asterisk-dev mailing list