[asterisk-dev] [Code Review] 4089: config: Fix infinite loop when using ast_category_browse and ast_variable_retrieve together.

[George Joseph]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4089/
-----------------------------------------------------------

(Updated Oct. 16, 2014, 11:18 a.m.)


Review request for Asterisk Developers, Joshua Colp and Matt Jordan.


Changes
-------

Fixed ast_variable browse and made sure no other searches by category name will have the problem.

Ran the full unit test and got the expected results.
Ran the testsuite SIP, pjsip and manager tests and got the expected results.


Repository: Asterisk


Description
-------

Fix infinite loop when calling ast_variable_retrieve inside a ast_category_browse loop when there are more than 1 category with the same name.

1 line removed from ast_category_browse_filtered.
A unit test added.
Language updated in config.h for ast_category_browse (not necessarily related to this issue).


Diffs (updated)
-----

  branches/12/tests/test_config.c 425698 
  branches/12/main/config.c 425698 
  branches/12/include/asterisk/config.h 425698 

Diff: https://reviewboard.asterisk.org/r/4089/diff/


Testing
-------

Existing and new unit test pass.
Testsuite tests/manager/config pass.


Thanks,

George Joseph

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20141016/76f35a1b/attachment.html>