[asterisk-dev] [Code Review] 4089: config: Fix infinite loop when using ast_category_browse and ast_variable_retrieve together.

[Joshua Colp]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4089/#review13545
-----------------------------------------------------------



branches/12/tests/test_config.c
<https://reviewboard.asterisk.org/r/4089/#comment24075>

    I don't think this test goes far enough. I'd make each category have different values for the variables and ensure that each retrieve in each category gets the right thing.


- Joshua Colp


On Oct. 16, 2014, 3:37 p.m., George Joseph wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/4089/
> -----------------------------------------------------------
> 
> (Updated Oct. 16, 2014, 3:37 p.m.)
> 
> 
> Review request for Asterisk Developers and Joshua Colp.
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> Fix infinite loop when calling ast_variable_retrieve inside a ast_category_browse loop when there are more than 1 category with the same name.
> 
> 1 line removed from ast_category_browse_filtered.
> A unit test added.
> Language updated in config.h for ast_category_browse (not necessarily related to this issue).
> 
> 
> Diffs
> -----
> 
>   branches/12/tests/test_config.c 425698 
>   branches/12/main/config.c 425698 
>   branches/12/include/asterisk/config.h 425698 
> 
> Diff: https://reviewboard.asterisk.org/r/4089/diff/
> 
> 
> Testing
> -------
> 
> Existing and new unit test pass.
> Testsuite tests/manager/config pass.
> 
> 
> Thanks,
> 
> George Joseph
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20141016/60c5862f/attachment-0001.html>