[asterisk-dev] [Code Review] 4084: res_pjsip_keepalive: Add keepalive module for connection-oriented transports.

[Joshua Colp]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4084/
-----------------------------------------------------------

(Updated Oct. 16, 2014, 11:24 a.m.)


Review request for Asterisk Developers.


Repository: Asterisk


Description
-------

Reusing connections is a good thing(tm). In the case of NAT it means that you have an actual way to exchange data back and forth. In practice, however, some things (such as PJSIP) close down the TCP connection after a short period of time (in the case of PJSIP for UAC it's 33 seconds). While PJSIP has a built in keepalive mechanism this is by default set to 90 seconds and can only be controlled at compile time.

The attached module implements its own keepalive which is configurable at runtime and does not require configuration. This sends a lightweight keepalive to keep the TCP (or TLS) connection open.


Diffs (updated)
-----

  /trunk/res/res_pjsip_keepalive.c PRE-CREATION 
  /trunk/res/res_pjsip/config_global.c 425689 
  /trunk/res/res_pjsip.c 425689 
  /trunk/include/asterisk/res_pjsip.h 425689 
  /trunk/configs/samples/pjsip.conf.sample 425689 

Diff: https://reviewboard.asterisk.org/r/4084/diff/


Testing
-------

Configured keepalives and used wireshark to verify that at the specific interval the message went out.


Thanks,

Joshua Colp

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20141016/a2263de2/attachment.html>