[asterisk-dev] [Code Review] 4083: testsuite: use replace instead of lstrip to remove portion of string

[wdoekes]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4083/#review13538
-----------------------------------------------------------



/asterisk/trunk/runtests.py
<https://reviewboard.asterisk.org/r/4083/#comment24065>

    (A) For get_path, I expect a full path to be returned and not something relative to something else. Perhaps get_tests_relpath()?
    
    (B) Did you find a case when not self.test_name.startswith('tests/') ? If not, then I'd do a:
    
        assert self.test_name.startswith('tests/'))
        return self.test_name[6:]
    
    If it turns out there is a valid reason that it doesn't start with tests/ then we can tackle that later.


- wdoekes


On Oct. 15, 2014, 4:53 p.m., Scott Griepentrog wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/4083/
> -----------------------------------------------------------
> 
> (Updated Oct. 15, 2014, 4:53 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Repository: testsuite
> 
> 
> Description
> -------
> 
> When a core dump occurs, if the test path started with t, e, or s, those characters would get stripped out from the path created to store the backtrace file.  This is due to incorrect usage of lstrip, which removes all instances of any of the provided characters from the start of the string regardless of the order:
> 
> >>> print 'tests/something'.lstrip('tests/')
> omething
> 
> This patch changes lstrip to replace in several places, where the intent was clearly to remove only an exact string from another.
> 
> 
> Diffs
> -----
> 
>   /asterisk/trunk/runtests.py 5730 
>   /asterisk/trunk/lib/python/asterisk/sippversion.py 5730 
> 
> Diff: https://reviewboard.asterisk.org/r/4083/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Scott Griepentrog
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20141016/d57d3482/attachment.html>