[asterisk-dev] [Code Review] 4062: PJSIP: Enforce module load dependencies

[Mark Michelson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4062/#review13535
-----------------------------------------------------------

Ship it!


This just sucks, but since the module loader can't do its job properly, I guess this is the next best thing.

- Mark Michelson


On Oct. 9, 2014, 2:30 p.m., opticron wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/4062/
> -----------------------------------------------------------
> 
> (Updated Oct. 9, 2014, 2:30 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Bugs: ASTERISK-24312
>     https://issues.asterisk.org/jira/browse/ASTERISK-24312
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> This enforces that res_pjsip, res_pjsip_session, and res_pjsip_pubsub have loaded properly before attempting to load any modules that depend on them since the module loader system is not currently capable of resolving module dependencies on its own.
> 
> 
> Diffs
> -----
> 
>   branches/12/res/res_pjsip_xpidf_body_generator.c 424849 
>   branches/12/res/res_pjsip_transport_websocket.c 424849 
>   branches/12/res/res_pjsip_t38.c 424849 
>   branches/12/res/res_pjsip_session.c 424849 
>   branches/12/res/res_pjsip_send_to_voicemail.c 424849 
>   branches/12/res/res_pjsip_sdp_rtp.c 424849 
>   branches/12/res/res_pjsip_rfc3326.c 424849 
>   branches/12/res/res_pjsip_registrar_expire.c 424849 
>   branches/12/res/res_pjsip_registrar.c 424849 
>   branches/12/res/res_pjsip_refer.c 424849 
>   branches/12/res/res_pjsip_pubsub.c 424849 
>   branches/12/res/res_pjsip_pidf_eyebeam_body_supplement.c 424849 
>   branches/12/res/res_pjsip_pidf_digium_body_supplement.c 424849 
>   branches/12/res/res_pjsip_pidf_body_generator.c 424849 
>   branches/12/res/res_pjsip_path.c 424849 
>   branches/12/res/res_pjsip_outbound_registration.c 424849 
>   branches/12/res/res_pjsip_outbound_authenticator_digest.c 424849 
>   branches/12/res/res_pjsip_one_touch_record_info.c 424849 
>   branches/12/res/res_pjsip_notify.c 424849 
>   branches/12/res/res_pjsip_nat.c 424849 
>   branches/12/res/res_pjsip_mwi_body_generator.c 424849 
>   branches/12/res/res_pjsip_mwi.c 424849 
>   branches/12/res/res_pjsip_multihomed.c 424849 
>   branches/12/res/res_pjsip_messaging.c 424849 
>   branches/12/res/res_pjsip_logger.c 424849 
>   branches/12/res/res_pjsip_header_funcs.c 424849 
>   branches/12/res/res_pjsip_exten_state.c 424849 
>   branches/12/res/res_pjsip_endpoint_identifier_user.c 424849 
>   branches/12/res/res_pjsip_endpoint_identifier_ip.c 424849 
>   branches/12/res/res_pjsip_endpoint_identifier_anonymous.c 424849 
>   branches/12/res/res_pjsip_dtmf_info.c 424849 
>   branches/12/res/res_pjsip_diversion.c 424849 
>   branches/12/res/res_pjsip_dialog_info_body_generator.c 424849 
>   branches/12/res/res_pjsip_caller_id.c 424849 
>   branches/12/res/res_pjsip_authenticator_digest.c 424849 
>   branches/12/res/res_pjsip_acl.c 424849 
>   branches/12/res/res_hep_pjsip.c 424849 
>   branches/12/include/asterisk/res_pjsip_session.h 424849 
>   branches/12/include/asterisk/res_pjsip_pubsub.h 424849 
>   branches/12/include/asterisk/res_pjsip.h 424849 
>   branches/12/channels/chan_pjsip.c 424849 
> 
> Diff: https://reviewboard.asterisk.org/r/4062/diff/
> 
> 
> Testing
> -------
> 
> Verified that this fixed the bug presented in ASTERISK-24312.
> 
> 
> Thanks,
> 
> opticron
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20141015/016b06b4/attachment-0001.html>