[asterisk-dev] [Code Review] 4074: AMI: Add missing VarSet events when a channel inherits variables.
Mark Michelson
reviewboard at asterisk.org
Wed Oct 15 15:39:53 CDT 2014
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4074/#review13528
-----------------------------------------------------------
Ship it!
Ship It!
- Mark Michelson
On Oct. 13, 2014, 7:54 p.m., rmudgett wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/4074/
> -----------------------------------------------------------
>
> (Updated Oct. 13, 2014, 7:54 p.m.)
>
>
> Review request for Asterisk Developers.
>
>
> Bugs: ASTERISK-24415
> https://issues.asterisk.org/jira/browse/ASTERISK-24415
>
>
> Repository: Asterisk
>
>
> Description
> -------
>
> There should be AMI VarSet events when channel variables are inherited by an outgoing channel. Also local;2 should generate VarSet events when it gets all of its channel variables from channel local;1.
>
>
> Diffs
> -----
>
> /branches/13/main/core_unreal.c 425404
> /branches/13/main/channel.c 425404
>
> Diff: https://reviewboard.asterisk.org/r/4074/diff/
>
>
> Testing
> -------
>
> PJSIP/100 dialing PJSIP/200 now has AMI VarSet events generated when PJSIP/200 inherits variables from PJSIP/100.
> AMI VarSet events are now generated for all channel variables initially passed from Local;1 to Local;2.
>
> Before this patch the AMI VarSet events didn't happen on channel variable inheritance and the initial Local;2 channel variables obtained from Local;1.
>
>
> Thanks,
>
> rmudgett
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20141015/a7c0c76c/attachment.html>
More information about the asterisk-dev
mailing list