[asterisk-dev] [Code Review] 4075: parking/tests: Running res_parking unit tests would cause assertions and possibly a crash due to attempting to play MOH on a channel with no formats
rmudgett
reviewboard at asterisk.org
Tue Oct 14 17:19:27 CDT 2014
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4075/#review13525
-----------------------------------------------------------
Ship it!
Ship It!
- rmudgett
On Oct. 14, 2014, 4:49 p.m., Jonathan Rose wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/4075/
> -----------------------------------------------------------
>
> (Updated Oct. 14, 2014, 4:49 p.m.)
>
>
> Review request for Asterisk Developers and Matt Jordan.
>
>
> Bugs: ASTERISK-24413
> https://issues.asterisk.org/jira/browse/ASTERISK-24413
>
>
> Repository: Asterisk
>
>
> Description
> -------
>
> This patch simply follows the suggested fix of specifying the format for test channels in the same manner as was done for the CDR unit tests.
>
>
> Diffs
> -----
>
> /branches/13/res/parking/parking_tests.c 425404
>
> Diff: https://reviewboard.asterisk.org/r/4075/diff/
>
>
> Testing
> -------
>
> Ran tests prior to patch and got assertions. Assertions no longer occurred with the patch in place.
>
>
> Thanks,
>
> Jonathan Rose
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20141014/5c443e00/attachment.html>
More information about the asterisk-dev
mailing list