[asterisk-dev] [Code Review] 4083: testsuite: use replace instead of lstrip to remove portion of string
Scott Griepentrog
reviewboard at asterisk.org
Tue Oct 14 17:00:27 CDT 2014
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4083/
-----------------------------------------------------------
Review request for Asterisk Developers.
Repository: testsuite
Description
-------
When a core dump occurs, if the test path started with t, e, or s, those characters would get stripped out from the path created to store the backtrace file. This is due to incorrect usage of lstrip, which removes all instances of any of the provided characters from the start of the string regardless of the order:
>>> print 'tests/something'.lstrip('tests/')
omething
This patch changes lstrip to replace in several places, where the intent was clearly to remove only an exact string from another.
Diffs
-----
/asterisk/trunk/runtests.py 5730
/asterisk/trunk/lib/python/asterisk/sippversion.py 5730
Diff: https://reviewboard.asterisk.org/r/4083/diff/
Testing
-------
Thanks,
Scott Griepentrog
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20141014/52f05fd8/attachment-0001.html>
More information about the asterisk-dev
mailing list