[asterisk-dev] [Code Review] 4075: parking/tests: Running res_parking unit tests would cause assertions and possibly a crash due to attempting to play MOH on a channel with no formats

[Jonathan Rose]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4075/
-----------------------------------------------------------

(Updated Oct. 14, 2014, 4:10 p.m.)


Review request for Asterisk Developers and Matt Jordan.


Changes
-------

Address a finding.

I also noticed that adding formats to this test caused the test channels to immediately be kicked out of the parking bridges causing the park_retrieval test to fail. To fix that I gave the channels read/write functions and a makeshift technology to use.


Bugs: ASTERISK-24413
    https://issues.asterisk.org/jira/browse/ASTERISK-24413


Repository: Asterisk


Description
-------

This patch simply follows the suggested fix of specifying the format for test channels in the same manner as was done for the CDR unit tests.


Diffs (updated)
-----

  /branches/13/res/parking/parking_tests.c 425404 

Diff: https://reviewboard.asterisk.org/r/4075/diff/


Testing
-------

Ran tests prior to patch and got assertions.  Assertions no longer occurred with the patch in place.


Thanks,

Jonathan Rose

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20141014/61fb8d4f/attachment.html>