[asterisk-dev] [Code Review] 4063: res_pjsip_session/res_pjsip_sdp_rtp: Fix a variety of situations where Asterisk would incorrectly reject offers

[Matt Jordan]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4063/
-----------------------------------------------------------

Review request for Asterisk Developers and Joshua Colp.


Bugs: ASTERISK-24122 and ASTERISK-24381
    https://issues.asterisk.org/jira/browse/ASTERISK-24122
    https://issues.asterisk.org/jira/browse/ASTERISK-24381


Repository: Asterisk


Description
-------

When an inbound SDP offer is received, Asterisk currently makes a few incorrection assumptions:

(1) If the offer contains more than a single audio/video stream, Asterisk will reject the entire stream with a 488. This is an overly strict response; generally, Asterisk should accept the media streams that it can accept and decline the others.
(2) If the offer contains a declined media stream, Asterisk will attempt to process it anyway. This can result in attempting to match format capabilities on a declined media stream, leading to a 488. Asterisk should simply ignore declined media streams.
(3) Asterisk will currently attempt to handle offers with AVPF with use_avpf=No/AVP with use_avpf=Yes. This mismatch results in invalid SDP answers being sent in response. If there is a mismatch between the media type being offered and the configuration, Asterisk must reject the offer with a 488.

This patch does the following:
* Asterisk will accept SDP offers with at least one media stream that it can use. Some WARNING messages have been dropped to NOTICEs as a result.
* Asterisk will not accept an offer with a media type that doesn't match its configuration.
* Asterisk will ignore declined media streams properly.


Diffs
-----

  /branches/13/res/res_pjsip_session.c 425502 
  /branches/13/res/res_pjsip_sdp_rtp.c 425502 

Diff: https://reviewboard.asterisk.org/r/4063/diff/


Testing
-------

A large number of automated tests have been added for this change, along with basic SDP Offer/Answer semantics. See https://reviewboard.asterisk.org/r/4079


Thanks,

Matt Jordan

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20141014/7f876bdd/attachment-0001.html>