[asterisk-dev] [Code Review] 4076: res_phoneprov: Create accessor for ast_phoneprov_std_variable_lookup.

[George Joseph]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4076/
-----------------------------------------------------------

(Updated Oct. 14, 2014, 12:02 p.m.)


Review request for Asterisk Developers and rmudgett.


Changes
-------

Addressed Richard's comments.


Repository: Asterisk


Description
-------

Based on feedback from Richard, I created an accessor for res_phoneprov/ast_phoneprov_std_variable_lookup and added load priority to AST_MODULE_INFO.

Richard, can you test this?  I don't see any difference in behavior before and after the change.  res_phoneprov has AST_MODFLAG_GLOBAL_SYMBOLS set so it should have always been loading before res_pjsip_phoneprov_provider which doesn't have that flag set, regardless of load priority.  You can't even modify that behavior in modules.conf.


Diffs (updated)
-----

  branches/12/res/res_pjsip_phoneprov_provider.c 425404 
  branches/12/res/res_phoneprov.c 425404 
  branches/12/include/asterisk/phoneprov.h 425404 

Diff: https://reviewboard.asterisk.org/r/4076/diff/


Testing
-------


Thanks,

George Joseph

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20141014/967a0291/attachment.html>