[asterisk-dev] [Code Review] 4049: res_fax: Fix reference leak caused by gateway sessions being added to faxregistry.container twice

[Corey Farrell]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4049/
-----------------------------------------------------------

(Updated Oct. 14, 2014, 11:44 a.m.)


Status
------

This change has been marked as submitted.


Review request for Asterisk Developers.


Changes
-------

Committed in revision 425457


Bugs: ASTERISK-24392
    https://issues.asterisk.org/jira/browse/ASTERISK-24392


Repository: Asterisk


Description
-------

Reserved fax gateway sessions are added to faxregistry.container, then added again when the session is 'really' created.  It seems that when it is re-added it adds a second reference into the container due to the id being different.  Removal of the original list entry is not successful.  This prevents the session from ever being unallocated.


Diffs
-----

  /branches/1.8/res/res_fax.c 424175 

Diff: https://reviewboard.asterisk.org/r/4049/diff/


Testing
-------

Verified this resolves the leak in 11 and 12.


Thanks,

Corey Farrell

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20141014/67696886/attachment.html>