[asterisk-dev] [Code Review] 4073: res_pjsip: Add 'user_eq_phone' option for placing 'user=phone' parameter in request URI if user is number.

[Olle E Johansson]

> On Oct. 13, 2014, 7:33 p.m., Matt Jordan wrote:
> > /trunk/res/res_pjsip/pjsip_configuration.c, line 1735
> > <https://reviewboard.asterisk.org/r/4073/diff/1/?file=68003#file68003line1735>
> >
> >     Alembic!
> >     
> >     Thinking about it, we also need to update Alembic with your optimistic encryption patch.
> >     
> >     Also: UPGRADE notes.
> 
> Joshua Colp wrote:
>     Wouldn't this belong in CHANGES? This isn't something that must be done when upgrading.

user=phone applies to the caller ID as well, the URI in the From: header. I made a patch for chan_sip to fix that not a long time ago. Maybe simple to fix if it's not already supported.


- Olle E


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4073/#review13498
-----------------------------------------------------------


On Oct. 13, 2014, 6:54 p.m., Joshua Colp wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/4073/
> -----------------------------------------------------------
> 
> (Updated Oct. 13, 2014, 6:54 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> This change adds a 'user_eq_phone' option to endpoints which, if set, will add a 'user=phone' parameter to the request URI if the user is determined to be a number.
> 
> 
> Diffs
> -----
> 
>   /trunk/res/res_pjsip/pjsip_configuration.c 425395 
>   /trunk/res/res_pjsip.c 425395 
>   /trunk/include/asterisk/res_pjsip.h 425395 
> 
> Diff: https://reviewboard.asterisk.org/r/4073/diff/
> 
> 
> Testing
> -------
> 
> Sent outgoing calls with various users (numbers, number+letters, letters) and confirmed that user=phone was set when it should be.
> 
> 
> Thanks,
> 
> Joshua Colp
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20141013/c1ff5bbb/attachment.html>