[asterisk-dev] [Code Review] 4072: Testsuite: Tests for manager GetConfig and UpdateConfig AMI actions

[Matt Jordan]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4072/#review13491
-----------------------------------------------------------

Ship it!



asterisk/trunk/tests/manager/config/ManagerConfigTest.py
<https://reviewboard.asterisk.org/r/4072/#comment24011>

    logger is usually upper case (by convention), although - as Walter pointed out - it technically doesn't have to be, as it isn't a constant.



asterisk/trunk/tests/manager/config/ManagerConfigTest.py
<https://reviewboard.asterisk.org/r/4072/#comment24010>

    I'd throw an ERROR message in here, just in case something eats the exception (which can happen in twisted)


- Matt Jordan


On Oct. 10, 2014, 4:57 p.m., George Joseph wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/4072/
> -----------------------------------------------------------
> 
> (Updated Oct. 10, 2014, 4:57 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Repository: testsuite
> 
> 
> Description
> -------
> 
> This is the test for manager GetConfig and UpdateConfig needed before https://reviewboard.asterisk.org/r/4033/ (has 2 Ship it's) can be committed.
> 
> 
> Diffs
> -----
> 
>   asterisk/trunk/tests/manager/tests.yaml 5714 
>   asterisk/trunk/tests/manager/config/test-config.yaml PRE-CREATION 
>   asterisk/trunk/tests/manager/config/ManagerConfigTest.py PRE-CREATION 
> 
> Diff: https://reviewboard.asterisk.org/r/4072/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> George Joseph
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20141011/2c4ab0fb/attachment.html>