[asterisk-dev] [Code Review] 4068: res_calendar_ews: Relax neon version check to work with 0.30 too.

[Matt Jordan]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4068/#review13487
-----------------------------------------------------------

Ship it!


Ship It!

- Matt Jordan


On Oct. 10, 2014, 7:11 a.m., wdoekes wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/4068/
> -----------------------------------------------------------
> 
> (Updated Oct. 10, 2014, 7:11 a.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Bugs: ASTERISK-24325
>     https://issues.asterisk.org/jira/browse/ASTERISK-24325
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> Debian allows res_calendar_ews to work with libneon-0.30.x as well as 0.29.x:
> 
> http://anonscm.debian.org/cgit/pkg-voip/asterisk.git/commit/debian/patches?id=fb53b262b78f3ce5f276a978b113a2965d2e6314
> https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=761677
> 
> Apparently that works even though libneon's ne_version_match claims that 0.x
> may be incompatible with 0.(x+1).
> 
> I see no reason why we should disallow that.
> 
> 
> Diffs
> -----
> 
>   /branches/1.8/res/res_calendar_ews.c 425067 
> 
> Diff: https://reviewboard.asterisk.org/r/4068/diff/
> 
> 
> Testing
> -------
> 
> Before:
> 
> *CLI> module load res_calendar_ews.so 
> [Oct 10 13:56:35] ERROR[17328]: res_calendar_ews.c:911 load_module:
>   Exchange Web Service calendar module require neon >= 0.29.1,
>   but neon 0.30.1: Library build, IPv6, Expat 2.1.0, zlib 1.2.8,
>   OpenSSL 1.0.1f 6 Jan 2014. is installed.
> Unable to load module res_calendar_ews.so
> Command 'module load res_calendar_ews.so ' failed.
> 
> 
> After:
> 
> it loads
> 
> 
> Thanks,
> 
> wdoekes
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20141010/3278cfa4/attachment.html>