[asterisk-dev] [Code Review] 4057: bridge: Every time a bridge lies during the smart bridge operation I cry

[rmudgett]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4057/#review13481
-----------------------------------------------------------

Ship it!


Comment nit.

Now if I can convince people to use the preincrement/predecrement form in stand alone statements instead of post-increment/post-decrement... :)


/branches/12/main/bridge.c
<https://reviewboard.asterisk.org/r/4057/#comment24003>

    ...re-add existing channels...


- rmudgett


On Oct. 9, 2014, 1:16 p.m., Joshua Colp wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/4057/
> -----------------------------------------------------------
> 
> (Updated Oct. 9, 2014, 1:16 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> Right now when a smart bridge operation occurs the bridge provided to the old technology is full of lies. This has the result of making technology implementations more complex because they can't assume the bridge is truthful, resulting in them storing more state than is needed or having additional code paths.
> 
> The attached change makes the bridge provided to the old technology truthful. The bridge will contain all the channels that are actually in the old bridge instead of none. As a result the bridge_native_rtp module can be made a bit dumber and slimmed down. This makes the smart bridge operation, to the old technology, a series of normal leave calls.
> 
> 
> Diffs
> -----
> 
>   /branches/12/main/bridge.c 424850 
>   /branches/12/bridges/bridge_native_rtp.c 424850 
> 
> Diff: https://reviewboard.asterisk.org/r/4057/diff/
> 
> 
> Testing
> -------
> 
> Performed calls and ran tests.
> 
> 
> Thanks,
> 
> Joshua Colp
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20141009/336125f6/attachment-0001.html>