[asterisk-dev] [Code Review] 4061: testsuite: Initial test for res_phoneprov

[Matt Jordan]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4061/#review13476
-----------------------------------------------------------

Ship it!


Both of these findings are minor, and I don't think they're sufficient to hold this up.

Thanks a lot for writing a test for this!


asterisk/trunk/tests/phoneprov/res_phoneprov/run-test
<https://reviewboard.asterisk.org/r/4061/#comment23997>

    You may want to use a LOGGER.error() here before re-raising the exception.
    
    Since this is in a separate process, runtests.py *should* capture that and spit it out, but just to be safe, the LOGGER error message will definitely provide the reason why the test failed.



asterisk/trunk/tests/phoneprov/res_phoneprov/test-config.yaml
<https://reviewboard.asterisk.org/r/4061/#comment23996>

    You may want to add Python dependencies on 'email'.
    
    The HTTP libraries are a bit trickier, since you fall back to one if the other isn't available. The dependency checking isn't good enough to handle that - although if you'd like, you could add a dependency on 'httplib', since twisted doesn't support Python 3.


- Matt Jordan


On Oct. 8, 2014, 7:46 p.m., George Joseph wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/4061/
> -----------------------------------------------------------
> 
> (Updated Oct. 8, 2014, 7:46 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Repository: testsuite
> 
> 
> Description
> -------
> 
> This is the first test for res_phoneprov.
> 
> 
> Diffs
> -----
> 
>   asterisk/trunk/tests/tests.yaml 5690 
>   asterisk/trunk/tests/phoneprov/tests.yaml PRE-CREATION 
>   asterisk/trunk/tests/phoneprov/res_phoneprov/test-config.yaml PRE-CREATION 
>   asterisk/trunk/tests/phoneprov/res_phoneprov/run-test PRE-CREATION 
>   asterisk/trunk/tests/phoneprov/res_phoneprov/configs/ast1/users.conf PRE-CREATION 
>   asterisk/trunk/tests/phoneprov/res_phoneprov/configs/ast1/phoneprov.conf PRE-CREATION 
>   asterisk/trunk/tests/phoneprov/res_phoneprov/cfgex.txt PRE-CREATION 
>   asterisk/trunk/tests/phoneprov/res_phoneprov/cfgbase.txt PRE-CREATION 
> 
> Diff: https://reviewboard.asterisk.org/r/4061/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> George Joseph
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20141009/ade927bf/attachment.html>